25 Oct
2021
25 Oct
'21
8:10 p.m.
Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58583 )
Change subject: pony_spi: fix memory leak ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58583/comment/3ab3a772_69dc3195 PS2, Line 9: free Please capitalize `Free`
https://review.coreboot.org/c/flashrom/+/58583/comment/f0908f32_cad2e736 PS2, Line 9: return This should be `returns`
https://review.coreboot.org/c/flashrom/+/58583/comment/3ee80ffb_f34dcd37 PS2, Line 9: failed I'd use timeless present: `fails`
--
To view, visit https://review.coreboot.org/c/flashrom/+/58583
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I11858bd0bdfe8b6d03af616fe4be4fb047b8dcd9
Gerrit-Change-Number: 58583
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Mon, 25 Oct 2021 20:10:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment