Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44580 )
Change subject: Add ENE LPC programmer ......................................................................
Patch Set 3:
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/44580/comment/ee2cda66_465b40a0 PS3, Line 177: endif
Why?
The code was ported from Chromium's flashrom fork, I don't think it has ever been verified on DOS; therefore, I decided this configuration shouldn't be allowed until tested when submitting this patch. WDYT?
https://review.coreboot.org/c/flashrom/+/44580/comment/ffca9ecf_af15850c PS3, Line 398: endif
Why?
The code was ported from Chromium's flashrom fork, I don't think it has ever been verified on libpayload; therefore, I decided this configuration shouldn't be allowed until tested when submitting this patch. WDYT?