17 May
2021
17 May
'21
1:50 p.m.
Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54356 )
Change subject: dummyflasher.c: Use BUS_NONSPI where appropriate ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/54356/comment/295b26d9_6c6ed2b3 PS1, Line 9: BUS_NONSPI is short-hand I have the question in my head for a while: what is BUS_PROG , because it is not included in BUS_SPI and not included in BUS_NONSPI ? I was just thinking that NONSPI is everything except SPI but this is not the case.
--
To view, visit https://review.coreboot.org/c/flashrom/+/54356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I368e8865c446d9b9ffd580c90eac034850dd53d8
Gerrit-Change-Number: 54356
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 17 May 2021 20:50:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment