Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48133 )
Change subject: ichspi.c: Implement ich_hwseq_get_flash_id() ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/48133/1/ichspi.c File ichspi.c:
https://review.coreboot.org/c/flashrom/+/48133/1/ichspi.c@1398 PS1, Line 1398: 1; also we should use 0 for non-error paths as it currently is a bit confused as well.