3 Aug
2019
3 Aug
'19
9:41 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34577 )
Change subject: tree: Enable -Wwrite-strings ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/34577/2/Makefile File Makefile:
https://review.coreboot.org/c/flashrom/+/34577/2/Makefile@33 PS2, Line 33: CFLAGS ?= -Os -Wall -Wshadow -Wmissing-prototypes -Wwrite-strings
Add to Meson as well?
Agreed. I wonder if there's a way to keep both build systems in sync.
--
To view, visit https://review.coreboot.org/c/flashrom/+/34577
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I62d9bc194938a0c9a0e4cdff7ced8ea2e14cc1bc
Gerrit-Change-Number: 34577
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 03 Aug 2019 21:41:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment