18 Apr
2021
18 Apr
'21
7:38 p.m.
Attention is currently required from: Sam McNally, Nico Huber, Stefan Reinauer. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49599 )
Change subject: flashrom.c: automatic generated programmer_enum.h ......................................................................
Patch Set 6:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/49599/comment/018cc561_7299734d PS4, Line 681: $(shell bash ./util/generator_programmer_enum.sh)
Sorry for the delay. I don't have much time and some effort the rework […]
Thank you. I know these, but this modification will be inconsistent with meson. In fact, regenerating every time has little effect on compilation speed.
--
To view, visit https://review.coreboot.org/c/flashrom/+/49599
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Gerrit-Change-Number: 49599
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Wang wxjstz@126.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Shawn C citypw@hardenedlinux.org
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 19 Apr 2021 02:38:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Xiang Wang wxjstz@126.com
Gerrit-MessageType: comment