Attention is currently required from: Nikolai Artemiev. Hello Nikolai Artemiev,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/62340
to review the following change.
Change subject: libflashrom: Allow NULL-pointer argument in flashrom_flash_release() ......................................................................
libflashrom: Allow NULL-pointer argument in flashrom_flash_release()
free() allows NULL and it makes error paths easier to handle when one just needs to write `free(x);` without needing to care if `x` was allocated already. Let's follow this rule in flashrom_flash_release(). flashrom_layout_release() already checks for NULL.
Change-Id: Id119c2e4f3aa1b11313059f11aac73c3e583185c Signed-off-by: Nico Huber nico.h@gmx.de --- M libflashrom.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/62340/1
diff --git a/libflashrom.c b/libflashrom.c index d66c295..5f14c68 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -361,6 +361,9 @@ */ void flashrom_flash_release(struct flashrom_flashctx *const flashctx) { + if (!flashctx) + return; + flashrom_layout_release(flashctx->default_layout); free(flashctx->chip); free(flashctx);