Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38488 )
Change subject: Automatic programmer driver writer ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/38488/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/38488/1//COMMIT_MSG@16 PS1, Line 16: for a in *; do test -f $a.mine && mv $a.mine $a; done
Shouldn’t we rely on the VCS to list the changes, and list newly added files (`git status`)?
No, that would also mess with files which you already changed manually. And a revert would then kill both the manual changes as well as the automatic changes. And running git status is not fun, especially when you're trying to write a driver and have other data files in the same directory.
https://review.coreboot.org/c/flashrom/+/38488/1//COMMIT_MSG@28 PS1, Line 28: Icdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcd000001
That is a weird Change-Id :D
Indeed, the Change-Id is freely selectable subject to some length and character set constraints. I might want to change it later.