Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83182?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: flashchips: Add Support for XMC XM25QH16C/XM25QH16D
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Kan, could you please rebase this patch on the latest main branch?
The reason is I merged your other patch CB:83180 and now this one has merge conflict, because both patch were adding new chip model id macro on line 850 in flashchips.h
This one can go to line 851 now.
You will need to sync your local repo, rebase this commit on top and push the patch again.
Thank you!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83182?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I215084ed33ca9261f6c7b91ef868ca8db85e61ad
Gerrit-Change-Number: 83182
Gerrit-PatchSet: 2
Gerrit-Owner: Ssunk
ssunkkan@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Ssunk
ssunkkan@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 27 Jun 2024 00:56:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
