Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39822 )
Change subject: flashchips: port S25FS(128S) chip from chromiumos
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/39822/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/39822/1//COMMIT_MSG@14
PS1, Line 14: For example, WIP status bit will remain being set to 1 if erase or
Please add exactly one blank line between paragraphs.
https://review.coreboot.org/c/flashrom/+/39822/1//COMMIT_MSG@75
PS1, Line 75:
Please mention more, where the Chromium OS implementation is.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/39822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If659290874a4b9db6e71256bdef382d31b288e72
Gerrit-Change-Number: 39822
Gerrit-PatchSet: 1
Gerrit-Owner: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Mar 2020 19:35:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment