Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38936 )
Change subject: raiden_debug: Upstream ChromiumOS usb_device helpers
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/38936/1/usb_device.c
File usb_device.c:
https://review.coreboot.org/c/flashrom/+/38936/1/usb_device.c@1
PS1, Line 1: /*
Do we want to name this usb_helpers. […]
I think that is a good name and that usbdev.c should be unified with this somehow perhaps? I think we should let the renaming happen once we have all the use cases merged (raiden_debug itself).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38936
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic928220fc919fe4958c8150e61e11470dac88f13
Gerrit-Change-Number: 38936
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Mar 2020 07:04:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment