Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48135 )
Change subject: ichspi.c: Implement ich_hwseq_{read,write}_status() callbacks
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/48135/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/48135/2//COMMIT_MSG@10
PS2, Line 10: rom
nit: if it's writable, it isn't a ROM (maybe use `flash` instead)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/48135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I47e257838ebd0eda04e08d15fbd0fcc3e439c247
Gerrit-Change-Number: 48135
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 30 Nov 2020 09:09:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment