24 Apr
2022
24 Apr
'22
10:35 p.m.
Attention is currently required from: Felix Singer, Nico Huber, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 )
Change subject: Introduce an `include` directory for header files ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58622/comment/2a0764c4_73aec586 PS3, Line 9: dicrectory
directory
Done
https://review.coreboot.org/c/flashrom/+/58622/comment/fdd8bb65_0e3cebe6 PS3, Line 10: buildsystems
Add a space in between
Done
https://review.coreboot.org/c/flashrom/+/58622/comment/42341bc0_4b407ba0 PS3, Line 10: `#include`s
nit: include directives
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/58622
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf
Gerrit-Change-Number: 58622
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth martinroth@google.com
Gerrit-CC: Peter Marheine pmarheine@chromium.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Sun, 24 Apr 2022 22:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Gerrit-MessageType: comment