Attention is currently required from: Nicholas Chin, ZhiYuanNJ.
Anastasia Klimchuk has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email )
Change subject: ch347_spi: Add spi clock frequency selection ......................................................................
Patch Set 14: Code-Review+2
(3 comments)
Patchset:
PS14: Nicholas, just wanted to check, do you approve the idea that we go ahead with the patch to add the feature with the same default as before (15MHz)? And then later, if decided so, the default can be changed in a separate patch.
File ch347_spi.c:
https://review.coreboot.org/c/flashrom/+/82776/comment/c594fba9_4068856e?usp... : PS11, Line 291: speed_index = 1;
But you haven't done? :) […]
Done
File ch347_spi.c:
https://review.coreboot.org/c/flashrom/+/82776/comment/491a81e1_d6d8fb84?usp... : PS13, Line 291: int speed_index = 2;
Good sense, sorry for the slow response, updated.
All good , thank you!