Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58270 )
Change subject: Makefile: move determination test for the endian in Makefile.d
......................................................................
Patch Set 5: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58270/comment/e343368d_a533dd55
PS5, Line 7: in
`to` or `into`
https://review.coreboot.org/c/flashrom/+/58270/comment/4ae39e9a_5c9fee6e
PS5, Line 7: move
It's more a copy. Together with the follow-up commit, it's a move. Maybe just
squash the two?
https://review.coreboot.org/c/flashrom/+/58270/comment/efe9c7f7_1966ac56
PS5, Line 9: a
`an`
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0c2420fd60d7d6a23c94c9962b06bfd7f3c86ad8
Gerrit-Change-Number: 58270
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 14 Oct 2021 12:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
