Attention is currently required from: Alan Green, Nico Huber, Samir Ibradžić.
Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Implement spi_send_multicommand()
......................................................................
Patch Set 26:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/40477/comment/e9f41c76_9c17c1b0
PS25, Line 10: seems to take always 2-3ms to respond.
Please no line breaks after a sentence. Either it's one paragraph […]
Done
https://review.coreboot.org/c/flashrom/+/40477/comment/bf79625d_dabc4c1b
PS25, Line 20: I am using ftdi-2232H chip. That is why I put it at this place.
: If anyone has a good overview about all programmers:
: This could be implemented in spi_write_cmd() in case that it is
: compatible to all programmers
: or this principle could be transfered to other programmers which act
: in a similar way.
It's already implemented, spi_send_multicommand() is […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 26
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alan Green
avg@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 09:34:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment