Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47005 )
Change subject: spi25.c: Use JEDEC consts in spi_simple_write_cmd() calls ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/47005/2/spi25.c File spi25.c:
https://review.coreboot.org/c/flashrom/+/47005/2/spi25.c@524 PS2, Line 524: 0xdb
this one isn't standard, I guess?
I looked for it and it didn't grep in spi.h so I left it for now.
https://review.coreboot.org/c/flashrom/+/47005/2/spi25.c@634 PS2, Line 634: return &spi_block_erase_dc;
I guess this could also be updated
I thought about it but figured its sort of easier to read with the magics but I wasn't sure so I left it out of this change for now.