Hello Sam McNally, build bot (Jenkins), Victor Ding,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/47353
to look at the new patch set (#2).
Change subject: programmer.h: Reorder MEC1308 and ENE_LPC enumerators ......................................................................
programmer.h: Reorder MEC1308 and ENE_LPC enumerators
Programmer enumerators and their corresponding programmer_table entries need to be aligned. This was not the case for MEC1308 and ENE_LPC. Their configs were not enabled by default until commit 26fde5b0b067 ("ene_lpc,mec1308: Fix entry-points to be explicit")/CL:2488823, allowing this issue to go unnoticed. The particular symptom of the mismatch was internal_init() trying to init linux_mtd instead of linux_spi.
BUG=b:172668501 TEST=flashrom -p host on gale BRANCH=None
Original-Change-Id: I2e9d3df6a6fd6d5d8e3a5a13ee56f5997b10ea52 Original-Signed-off-by: Sam McNally sammc@chromium.org
Change-Id: I8e7a57b7c30e2dd2306d6fe7268eee8bb9d0c8a5 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M programmer.h 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/47353/2