Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33346 )
Change subject: ft2232_spi.c: Remove unneeded 'else' ......................................................................
ft2232_spi.c: Remove unneeded 'else'
'else' is not needed after a 'break' or 'return'.
Change-Id: Ia4762d0c0601d56528de56658b869b62fbe5b263 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/flashrom/+/33346 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M ft2232_spi.c 1 file changed, 4 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/ft2232_spi.c b/ft2232_spi.c index 95584aa..5c4d06b 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -321,9 +321,8 @@ "Valid are even values between 2 and 131072.\n", arg); free(arg); return -2; - } else { - divisor = (uint32_t)temp; } + divisor = (uint32_t)temp; } free(arg);
@@ -336,11 +335,10 @@ "Valid values are between 0 and 3.\n", arg); free(arg); return -2; - } else { - unsigned int pin = temp + 4; - cs_bits |= 1 << pin; - pindir |= 1 << pin; } + unsigned int pin = temp + 4; + cs_bits |= 1 << pin; + pindir |= 1 << pin; } free(arg);