13 Nov
2020
13 Nov
'20
11:47 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47091 )
Change subject: chipset_enable.c: Add Geminilake support ......................................................................
Patch Set 4:
Uh, Gemini Lake has a different descriptor layout. This change as-is will make flashrom assume an invalid descriptor (that for WildcatPoint). While the APL layout is good enough, there's a few differences to account for.
I've got CB:43349 which handles this, but I went berserk and made a full descriptor dumper out of it...
--
To view, visit https://review.coreboot.org/c/flashrom/+/47091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I533a426bbf8e9c5efef0cf693693086e8efc1f57
Gerrit-Change-Number: 47091
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Nov 2020 11:47:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment