Hello Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/32891
to review the following change.
Change subject: usbdev: Only match requested USB devices ......................................................................
usbdev: Only match requested USB devices
Don't use a device that has the same vendor ID, but a different than requested product ID.
Fixes broken dediprog detection with TOMU in use.
Change-Id: I08c1c363ce2d6603e46efecc61d3910e02314fca Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M usbdev.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/32891/1
diff --git a/usbdev.c b/usbdev.c index d793b65..764ac04 100644 --- a/usbdev.c +++ b/usbdev.c @@ -54,7 +54,7 @@ continue; }
- if ((desc.idVendor != vid) && (desc.idProduct != pid)) + if ((desc.idVendor != vid) || (desc.idProduct != pid)) continue;
msg_pdbg("Found USB device %04"PRIx16":%04"PRIx16" at address %d-%d.\n",