Attention is currently required from: Alexander Goncharov, Fabrice Fontaine, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78930?usp=email )
Change subject: Makefile: CONFIG_INTERNAL depends on raw mem access ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/78930/comment/b9f4704d_d3048704 : PS1, Line 17: If you could add here in commit message testing info (which environment with which exactly options you tested with) that would be great, thank you!
Patchset:
PS1:
Thanks for the patch! […]
I opened the link from commit message, flashrom is build with the following:
CONFIG_FT2232_SPI=no CONFIG_USBBLASTER_SPI=no CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=yes CONFIG_ENABLE_LIBPCI_PROGRAMMERS=yes
which is without internal programmer.
I have another question that I am wondering about, it there anything to change in meson.build. I just looked through it, seems all good?