29 Jan
2021
29 Jan
'21
12:53 a.m.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47908 )
Change subject: Makefile: Explicitly set '-std=c99' ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Hi Idwer, POSIX_C_SOURCE=200809L is required for fileno, nanosleep, and strndup. […]
Hi Edward,
'gmake' on BSD is broken, and hacks (see git diff) yet have to act as intended: https://paste.flashrom.org/view.php?id=3438
There was an issue with cbfstool earlier, having had a look at OS code I conclused that it should be solvable. https://github.com/freebsd/freebsd-src/blob/main/sys/sys/types.h#L55 https://review.coreboot.org/c/coreboot/+/49314
--
To view, visit https://review.coreboot.org/c/flashrom/+/47908
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4f973927fc018510a3beaa6c4fa2f356c77c7a6e
Gerrit-Change-Number: 47908
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Jan 2021 22:53:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Idwer Vollering vidwer@gmail.com
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment