Attention is currently required from: Drew Fustini, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51113 )
Change subject: Add support for GD25LQ256D ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I have to admit this is the first time I've looked at the flashrom source code so I may not be the b […]
Please test the changes that Angel suggested.
One thing about write tests: flashrom compares the current contents of the flash chip to the provided data. If they are equal, flashrom does nothing. In your verbose write log you can actually see that. In the list of blocks in the end:
0x000000-0x000fff:S
The S tells us that the block was *S*kipped. All of them, it seems. To really test writes, one could use random data, e.g.
dd if=/dev/urandom bs=1M count=32 of=random.rom flashrom -p ... -w random.rom
If that says VERIFIED, we're all good.
Also, if you have the time, it would be nice to test these additional feature flags:
* FEATURE_4BA_READ, * FEATURE_4BA_WRITE, and * FEATURE_4BA_EXT_ADDR (this last one without any other FEATURE_4BA*)
each with new random data.