Attention is currently required from: Daniel Campello, Anastasia Klimchuk.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62862 )
Change subject: helpers.c: use unsigned it for bit shifts (ASAN)
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62862/comment/04178425_60623d89
PS1, Line 7: it
int?
Patchset:
PS1:
The shift stuff would probably also be detected by some GCC warning.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib595f13c29dd5c0775e074801756e4f920b4daaf
Gerrit-Change-Number: 62862
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 16 Mar 2022 14:21:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment