29 Nov
2022
29 Nov
'22
2:50 p.m.
Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Evan Benn.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70027 )
Change subject: libflashrom: Define macro to detect v1.3 header ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Heres what SDL does, […]
The current macro looks like a stub. As far as I know, nothing prevents us from adding a normal version system, so +1 for Evan's ideas.
--
To view, visit https://review.coreboot.org/c/flashrom/+/70027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iac35ff167272e1bc3d5434f7b47099f53bfceab7
Gerrit-Change-Number: 70027
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Evan Benn evanbenn@google.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Evan Benn evanbenn@google.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 14:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Evan Benn evanbenn@google.com
Gerrit-MessageType: comment