Attention is currently required from: Victor Ding, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56102 )
Change subject: spi_master: Add default write_aai function to masters that have none
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Victor, thank you, if you could get this information that would be great! […]
I think we can go ahead with this but should keep in mind that we need
to analyze what makes sense to upstream and what doesn't. And we have
to stop upstreaming untested code (I mean just a blunt run it on the
respective hardware and see if it does something; that would be a start).
This is actually not the first time this happened: the `it85spi` driver was
also upstreamed from chromium about a decade ago, and is not hooked up
anywhere yet ;) Nobody cares about these EC drivers, nobody hooks them
up correctly. Still, we maintain their code?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219
Gerrit-Change-Number: 56102
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Victor Ding
victording@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Victor Ding
victording@google.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Sat, 10 Jul 2021 12:04:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Victor Ding
victording@google.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment