Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37264 )
Change subject: pcidev.c: Factor out pcidev_validate() into pure fn
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/37264/2/pcidev.c
File pcidev.c:
https://review.coreboot.org/c/flashrom/+/37264/2/pcidev.c@158
PS2, Line 158: continue;
What happened to the vendor_id check?
https://review.coreboot.org/c/flashrom/+/37264/2/pcidev.c@254
PS2, Line 254: return dev;
So we always return NULL now (only state that can exit the loop)? Was this tested? ;-P
--
To view, visit
https://review.coreboot.org/c/flashrom/+/37264
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia2718f1f40851d3122741cd0e50b0c2b647b727a
Gerrit-Change-Number: 37264
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 09 Dec 2019 15:53:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment