Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Adds support for USB SPI protocol V2 ......................................................................
Patch Set 10:
(8 comments)
https://review.coreboot.org/c/flashrom/+/41533/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/41533/10//COMMIT_MSG@7 PS10, Line 7: Adds Add
https://review.coreboot.org/c/flashrom/+/41533/10//COMMIT_MSG@9 PS10, Line 9: Adds Add
https://review.coreboot.org/c/flashrom/+/41533/10//COMMIT_MSG@9 PS10, Line 9: documentation of it its documentation
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@450 PS10, Line 450: #define PAYLOAD_SIZE_V2_START (58) : : #define PAYLOAD_SIZE_V2_RESPONSE (60) : : #define PAYLOAD_SIZE_V2_CONTINUE (60) : : #define PAYLOAD_SIZE_V2_ERROR (60) This is V2, maybe put it next to the other V2 definitions?
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@875 PS10, Line 875: " protocol = %u\n" This isn't aligned with the other definitions
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@930 PS10, Line 930: Double empty line
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@950 PS10, Line 950: unsigned int I'd rather declare loop variables outside of the loop body for compatibility purposes. See CB:38034 for the reasons.
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@1112 PS10, Line 1112: Two spaces