29 Aug
2020
29 Aug
'20
8:33 p.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44420 )
Change subject: Add support for Comet Lake-U/400-series PCH ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/44420/2/chipset_enable.c File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/44420/2/chipset_enable.c@2016 PS2, Line 2016: {0x8086, 0x02a4, B_S, DEP, "Intel", "Comet Lake", enable_flash_pch400},
Wait... That's the ID of the 1f.5 device, so it shouldn't be added here. Sorry for the confusion.
you're right, so why was it being added in 44921 ?
--
To view, visit https://review.coreboot.org/c/flashrom/+/44420
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43b4ad1eecfed16fec59863e46d4e997fbe45f1b
Gerrit-Change-Number: 44420
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Joshua Wise joshua@joshuawise.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 29 Aug 2020 20:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment