Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41655 )
Change subject: tests/: Add helper.c unit tests ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/41655/1/tests/helpers.c File tests/helpers.c:
PS1:
Should we have more test cases in the future?
Absolutely, I just want to get things started with worked examples and lay the foundations.
I will work on pushing more with we can get this initial series in.
https://review.coreboot.org/c/flashrom/+/41655/1/tests/helpers.c@52 PS1, Line 52: assert_int_equal(0x5A, reverse_byte(0x5A));
0x5A = 0101_1010
yes? byte is reversed.