Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34584 )
Change subject: Add support for continuous SPI reads ......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
This is obsolete. We changed the spi_read_chunked() implementation long ago, because nobody knew any SPI flash that would have a page- size limitation for reads. So far nobody complained.
Nice to see, though, that my patches get around :)
Thanks for the review Nico, do you mind pointing me to the commit you are referring to so I can get my head around reconciling the differences between the two trees.
We have a feature flag for chips called UNBOUND_READ that builds on top of this, are you suggesting that is completely obsolete and not needed for each chip definition now?