Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47276 )
Change subject: flashrom.c: implement chip restore callback registration
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/flashrom/+/47276/1/flashrom.c
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/47276/1/flashrom.c@592
PS1, Line 592: register_chip_restore
We should either store a callback in the flashchip structure or have an array of callbacks in the fl […]
Ack
https://review.coreboot.org/c/flashrom/+/47276/1/flashrom.c@653
PS1, Line 653:
: static int chip_restore()
Done, but maybe we should chose a name that indicates that it will actually call the chip restore fu […]
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2a522dc1fd3952793fbcad70afc6dd43850fbbc5
Gerrit-Change-Number: 47276
Gerrit-PatchSet: 11
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrew McRae
amcrae@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Comment-Date: Thu, 03 Dec 2020 12:29:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment