Attention is currently required from: Nico Huber, Subrata Banik, Edward O'Callaghan.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64968 )
Change subject: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64968/comment/406aa05a_711a3b48
PS6, Line 7: ichspi.c: Use mmio_W,R(ich_spibar + X) macros consistently
I rather would like to use the functions instead of the macros.
https://review.coreboot.org/c/flashrom/+/64968/comment/95abb93c_b21e8c6b
PS6, Line 14: TEST=builds
As far as I can see, the binary shouldn't change. Please make sure this is the case.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8c90ea1ff617a451a671827d7bc49679d349c79d
Gerrit-Change-Number: 64968
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Wed, 21 Sep 2022 13:40:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment