Nico Huber has posted comments on this change. ( https://review.coreboot.org/18962 )
Change subject: ichspi: Add support for Intel Skylake
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/18962/4/ich_descriptors.c
File ich_descriptors.c:
Line 920: for (i = 0; i <= nr; i++)
Here, nr could be == 5 (above check is for nr > 5, not nr >= 5), and the lo
Must have happened while juggling with commits. I fixed it again
later in the series.
--
To view, visit
https://review.coreboot.org/18962
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4565a3c39f5fe3aec4fc8863605cebed1ad4ee
Gerrit-PatchSet: 4
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Tauner
stefan.tauner@gmx.at
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes