Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34160 )
Change subject: dediprog.c: Add id parameter to dediprog programmer
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Looks good but for one tiny thing...
https://review.coreboot.org/c/flashrom/+/34160/4/dediprog.c
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/34160/4/dediprog.c@1206
PS4, Line 1206: if (id != -1) {
This is always true, right? `id` can't have changed since we checked this in
line 1186, can it?
Oh, now I see, it's just a left-over from the old version, isn't it?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/34160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4281213ab02131feb5d47bf66118a001cec0d219
Gerrit-Change-Number: 34160
Gerrit-PatchSet: 4
Gerrit-Owner: Ryan O'Leary
ryanoleary@google.com
Gerrit-Assignee: Ryan O'Leary
ryanoleary@google.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Ryan O'Leary
ryanoleary@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 13 Nov 2019 13:23:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment