Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 )
Change subject: tree: provide flashrom context into programmer_delay() ......................................................................
Patch Set 11:
(1 comment)
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/66373/comment/e77e5c28_eac9ecdf PS11, Line 80: flash, A lot of lines changed in this patch with some plumbing actually don't need that much of a change, you can just pass `NULL`. The only two programmers that have special delays hooked are:
``` ch341a_spi.c: .delay = ch341a_spi_delay, serprog.c: .delay = serprog_delay, ```
so all other programmers can just use `NULL` as the context which allows them to default to 'internal_delay()' and only core logic requires the plumbing like for spi25.c, spi25_statusreg.c, s25f.c, jedec.c && flashrom.c
A subsequent patch could be prepared that greps for all the `programmer_delay(NULL, [..])` instances and just does a find and replace with `internal_delay([..])`.
Almost all programmers do not need such indirection where they are simply just trying to call `internal_delay()`.