Attention is currently required from: Evan Benn.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72004 )
Change subject: flashrom_tester: Use Range and usize for all ranges
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/72004/comment/16394ea6_96f0796d
PS5, Line 56: usize
yes this is where we get into the mess of the flashrom API types. getsize returns a `size_t`. […]
I think you're right that we've covered this before. Sure, let's stick with usize.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic09be66c3598acf45fbe8952093006a9b185810a
Gerrit-Change-Number: 72004
Gerrit-PatchSet: 7
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Evan Benn
evanbenn@google.com
Gerrit-Comment-Date: Wed, 18 Jan 2023 22:45:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Evan Benn
evanbenn@google.com
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment