Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64425 )
Change subject: flashchips.c: Fix 4BA for S25FL512S ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: NB. It's rather nuts how many different ways the manufacturers invented to support 4-byte addresses. It makes flashrom annoyingly complex in this area (I guess at least when one is not used to all the different concepts). So far I had no good idea how to handle things better. Maybe we could try to add missing feature flags (like those 0x16/0x17 opcodes) and align the names better with datasheets (if there are similarities; for instance, today I read a lot "bank address register" instead of extended address register, but this might be just coincidence).