Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 )
Change subject: [WIP] meson: rework the programmer selection ......................................................................
Patch Set 7:
(3 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/63724/comment/e4982333_0e97ac5a PS7, Line 212: 'internal' : { : 'systems' : systems_raw_hwaccess + ['linux'], : 'cpu_families' : (host_machine.system() == 'linux' ? [host_machine.cpu_family()] : ['x86', 'x86_64']), : 'deps' : [ libpci ], : 'groups' : [ ], : 'srcs' : (host_machine.cpu_family() in ['x86', 'x86_64'] ? files( : 'processor_enable.c', : 'chipset_enable.c', : 'board_enable.c', : 'cbtable.c', : 'internal.c', : 'it87spi.c', : 'it85spi.c', : 'sb600spi.c', : 'amd_imc.c', : 'wbsio_spi.c', : 'mcp6x_spi.c', : 'ichspi.c', : 'dmi.c', : 'pcidev.c', : ) : files( : 'board_enable.c', : 'cbtable.c', : 'chipset_enable.c', : 'internal.c', : 'processor_enable.c', : 'pcidev.c', : )), : 'flags' : [ : '-DCONFIG_INTERNAL=1', : '-DCONFIG_INTERNAL_DMI=' + (get_option('use_internal_dmi') ? '1' : '0'), : ] : },
I remember there was a conversation about internal, that it needs a refactoring to make the array id […]
This should work. I only discovered this possibility while working on the code. I still prefer to split the internal programmer. But now it is not important any longer for the build system change.
https://review.coreboot.org/c/flashrom/+/63724/comment/a7a79a9d_2ac35f10 PS7, Line 484: srcs += 'bitbang_spi.c'
oh... […]
No, it just was guarded with `need_bitbang_spi`. I've just put it to the common code.
File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/63724/comment/635985df_3b6e7173 PS7, Line 6: choices
Just checking, this is an array, so it allows having combinations like […]
yes, the choices ensure at least one programmer is enabled, there can't be a string which is no programmer, so typos will get detected here, you can select one and more programmer. E.g. `-Dprogrammer=auto,ch341a_spi` will select all available programmer, but forces to compile the ch341a_spi or fail.