Attention is currently required from: Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62777 )
Change subject: tests/: Factor out all link-time wrapped func
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
That's a good idea, and I was thinking about something similar too, so thank you! :)
When I was thinking about it, I was going to have port io wraps it their own file.
Second thing is that this patch needs to, if possible, wait for CB:63489 to get merged.
I suggest, don't do anything right now (just to save time), let's get meson compiler options done and then come back to this one? is that okay?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62777
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e18c9390c064a3112caa7f5778569ae478552d
Gerrit-Change-Number: 62777
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 26 Apr 2022 00:15:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment