Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33651 )
Change subject: spi: Drop spi_controller type
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33651/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33651/2//COMMIT_MSG@9
PS2, Line 9: to
: layering
Oh, looks like you are right. In German we have rather similar […]
I see. I would have added a verb: Drop it fast before it encourages anyone to *commit* layering violations again!
I specifically like the word "commit" because it refers to the git commit, but also because of its meaning: "perpetrate or carry out (a mistake, crime, or immoral act)", which perfectly fits the situation :)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8eda93b429e3ebaef79e22aba76be62987e496f4
Gerrit-Change-Number: 33651
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Jun 2019 11:31:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment