Jacob Creedon has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34413 )
Change subject: flashchips: Fill out support for N25Q/MT25Q chips ......................................................................
Patch Set 4:
(2 comments)
I've cleaned up the patch and split them out into more easily reviewed patches. I will abandon this review and open up new ones for the new patch stack. Thanks!
https://review.coreboot.org/c/flashrom/+/34413/2/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34413/2/flashchips.c@10608 PS2, Line 10608: }, {
We handle such differences with multiple chip definitions that share the ID. Flashrom […]
Done
https://review.coreboot.org/c/flashrom/+/34413/2/flashchips.c@10616 PS2, Line 10616: .block_erase = spi_block_erase_c7,
I'm new to this codebase so I don't know the best way to address this issue. […]
Done