Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54170 )
Change subject: programmer: Smoothen register_opaque_master() API
......................................................................
Patch Set 1:
(1 comment)
File nicintel_eeprom.c:
https://review.coreboot.org/c/flashrom/+/54170/comment/f6061d13_08916697
PS1, Line 489: return register_opaque_master(&opaque_master_nicintel_ee_82580, NULL);
My comment here: this has a piece of data (eecp), but the data was only passed to register_shutdown, and was not passed to register_opaque_master via opaque_master struct. Opaque master struct was const, and it stays const.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54170
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id3adb4cf04ae04dbe87ddb96f30871cb5f7c8ff0
Gerrit-Change-Number: 54170
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 13 May 2021 03:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
