Attention is currently required from: Jonathon Hall.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67619 )
Change subject: flashrom.c: Don't crash when programmer parameter string is NULL ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67619/comment/7a7a3639_ea39621a PS1, Line 9: commit 3b8b93e
I commented on CB:66659 about the biggest problems I saw. […]
Thanks for the comments on CB:66659 shame not to have caught them in the week before 😞
Not sure what you mean that CB:67094 is a great starting point? It doesn't constraint `programmer_param` to `programmer_init()` it is still accessed in `extract_programmer_param_str()`. As you said one would only need to plumb but only because of all the prior work so why not just go all the way and have this commit fixed up rather than abandoned? CB:67094 is merely a half realised variant of this patch or CB:66659. The overall patch intent doesn't appear to be the issue just some very unfortunate teething issues that got missed in the switch over.