Attention is currently required from: Edward O'Callaghan, Evan Benn.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69403 )
Change subject: flashrom_tester: Log some cros lsb-release information
......................................................................
Patch Set 4:
(1 comment)
File util/flashrom_tester/src/tests.rs:
https://review.coreboot.org/c/flashrom/+/69403/comment/2d9bd91b_5cd8e3fa
PS3, Line 137: CROS
do you want this to read 'Unknown CROS Distro'?
I might even skip setting this if you don't find anything, but perhaps "Unknown or not a ChromeOS release" is good: a system that doesn't have a CHROMEOS_RELEASE_DESCRIPTION probably isn't Chrom{ium,}OS at all, rather than an unidentifiable version.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69403
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If3452ead9e02e0ddeaa0fdf4852d7c17a8ab7650
Gerrit-Change-Number: 69403
Gerrit-PatchSet: 4
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Evan Benn
evanbenn@google.com
Gerrit-Comment-Date: Thu, 10 Nov 2022 22:26:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Evan Benn
evanbenn@google.com
Gerrit-MessageType: comment