Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33836 )
Change subject: flashchips.c: Replace comment with #if 0
......................................................................
Patch Set 7:
Patch Set 7:
Not sure if this entry should just be removed.
I agree, it should either be finished (i.e. add erasers
and voltage range) or just dropped. The comment could be
moved to AT25DF321 in the latter case.
If the datasheet is available, I would prefer to make
it whole entry.
Looks like the datasheet exists: https://cdn.hackaday.io/files/7758331918272/AT26DF321.pdf
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33836
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384
Gerrit-Change-Number: 33836
Gerrit-PatchSet: 7
Gerrit-Owner: Alan Green
avg@google.com
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jul 2019 10:25:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment