Attention is currently required from: Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 )
Change subject: ichspi.c: Read chip ID and use it to identify chip ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69195/comment/26bea737_a2efa6a2 PS2, Line 7: ichspi.c: Read chip ID and use it to identify chip Knowing the chip shouldn't matter for hwseq, as we're not sending direct commands anyway.
Also, what about systems with two flash chips? Yes, they exist (Ivy Bridge and Haswell ThinkPads, for example), and flashrom always uses hwseq.
https://review.coreboot.org/c/flashrom/+/69195/comment/605ea5a4_e66693e7 PS2, Line 9: BUG=b:253715389,b:253713774 Out of curiosity, what are these bug tracker entries about?