David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33613 )
Change subject: spi: Move 16MiB partitioning up into spi_chip_read()
......................................................................
Patch Set 2: Code-Review+2
It's worth pointing out that this makes the loop look a lot less like the one in spi_write_chunked(). spi_write_chunked() should probably also be simplified with alignment done at a higher-level such that the page and eraseblock alignment are consolidated (since we may need to write additional pages within an eraseblock to restore old contents).
But that's for another patch...
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33613
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iab1fd5b2ea550b4b3ef3e8402e0b6ca218485a51
Gerrit-Change-Number: 33613
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@chromium.org
Gerrit-Comment-Date: Thu, 20 Jun 2019 00:02:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment