Attention is currently required from: Alan Green, Paul Menzel, Angel Pons.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49637 )
Change subject: ft2232_spi.c: Generalized GPIOL pin control
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Patchset:
PS5:
Very good, this is a more flexible option
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/49637/comment/554f1272_6cc41374
PS5, Line 381:
Using the default value can work, but it is recommended to add the following code to make the meaning clearer.
cs_bits &= ~(1 << pin);
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49637
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1f2b3b968577e62e3c5b11bcdf4afe2de6eb84ab
Gerrit-Change-Number: 49637
Gerrit-PatchSet: 5
Gerrit-Owner: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Alan Green
avg@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 20 Jan 2021 06:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment